Skip to content

fix(mcp): Add None checks#6219

Merged
alexander-alderman-webb merged 3 commits intowebb/test-ci-3from
webb/mcp-mypy
May 7, 2026
Merged

fix(mcp): Add None checks#6219
alexander-alderman-webb merged 3 commits intowebb/test-ci-3from
webb/mcp-mypy

Conversation

@alexander-alderman-webb
Copy link
Copy Markdown
Contributor

@alexander-alderman-webb alexander-alderman-webb commented May 7, 2026 •
edited
Loading

Description

sentry_sdk/integrations/mcp.py:499: error: Item "None" of "Any | None" has no attribute "scheme"  [union-attr]
sentry_sdk/integrations/mcp.py:642: error: Item "None" of "Any | None" has no attribute "_get_prompt_mcp"  [union-attr]
sentry_sdk/integrations/mcp.py:656: error: Item "None" of "Any | None" has no attribute "_get_prompt_mcp"  [union-attr]
sentry_sdk/integrations/mcp.py:659: error: Item "None" of "Any | None" has no attribute "_read_resource_mcp"  [union-attr]
sentry_sdk/integrations/mcp.py:673: error: Item "None" of "Any | None" has no attribute "_read_resource_mcp"  [union-attr]

Issues

Reminders

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 7, 2026 •
edited
Loading

Codecov Results 📊

✅ 146 passed | Total: 146 | Pass Rate: 100% | Execution Time: 21.68s

📊 Comparison with Base Branch

Metric Change
Total Tests —
Passed Tests —
Failed Tests —
Skipped Tests —

✨ No test changes detected

All tests are passing successfully.

❌ Patch coverage is 0.00%. Project has 14495 uncovered lines.
❌ Project coverage is 33.75%. Comparing base (base) to head (head).

Files with missing lines (1)
File Patch % Lines
mcp.py 5.86% ⚠️ 257 Missing
Coverage diff 
@@            Coverage Diff             @@
##          main       #PR       +/-##
==========================================
- Coverage    34.98%    33.75%    -1.23%
==========================================
  Files          190       190         —
  Lines        21877     21880        +3
  Branches      7360      7366        +6
==========================================
+ Hits          7652      7385      -267
- Misses       14225     14495      +270
- Partials       800       743       -57

Generated by Codecov Action

@alexander-alderman-webb alexander-alderman-webb marked this pull request as ready for review May 7, 2026 09:44
@alexander-alderman-webb alexander-alderman-webb requested a review from a team as a code owner May 7, 2026 09:44
@alexander-alderman-webb alexander-alderman-webb merged commit f2cb5b4 into webb/test-ci-3 May 7, 2026
148 of 149 checks passed
@alexander-alderman-webb alexander-alderman-webb deleted the webb/mcp-mypy branch May 7, 2026 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sentrivana sentrivana sentrivana approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alexander-alderman-webb @sentrivana